refactor: move doc to docs, use _build instead of build #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/tweaks-to-docs-ci
branch
from
28e6166
to
15bbf9c
Compare
manics
approved these changes
Dec 21, 2021
|
@manics thank you for helping out with review across the entire JupyterHub org! You are amazing! ❤️ 🎉
The Python.gitignore file maintained in a GitHub repo was copy pasted, which replaced some changes that had been made within that section in the past. So now, what you see under that section is 100% copy-pasted, while everything else is custom additions. |
|
I'm about to make additional changes in another PR, so instead of getting additional merge conflicts stacking up. I'll resolve these and get this merged now. |
consideRatio
force-pushed
the
pr/tweaks-to-docs-ci
branch
from
15bbf9c
to
b88ba30
Compare
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Dec 22, 2021
jupyterhub/zero-to-jupyterhub-k8s#2521 Merge pull request #2521 from consideRatio/pr/tweaks-to-docs-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It bugged me a bit that this project specifically in the jupyterhub organization opted to use different folder names for the documentation than other projects in the jupyterhub org.
This PR renames the doc folder to docs, and builds to docs/_build instead of docs/build. It also updates .gitignore a bit which partially is relevant for this change.