Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add changelog for 2.0.0 (beta.1) #2528

Merged
merged 5 commits into from Aug 16, 2022

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Dec 27, 2021

Updated and ready for review. We will use JupyterHub 3.0.0b1 for z2jh 2.0.0-beta.1

CHANGELOG.md Outdated Show resolved Hide resolved
@consideRatio consideRatio marked this pull request as draft May 5, 2022 09:25
@dhirschfeld
Copy link
Contributor

👋 Hi, I'm currently on 1.2.0 and am just trying to figure out when 2.0.0 will be released.

Are there any concrete plans to release 2.0.0 imminently? Is there a better issue or place I can track progress?

@consideRatio
Copy link
Member Author

consideRatio commented May 22, 2022

Needs to be done

Here are things I'd like to see done before we agree to merge a changelog and cut a release that I can quickly name from the top of my head.

@consideRatio consideRatio mentioned this pull request Jun 5, 2022
8 tasks
CHANGELOG.md Outdated Show resolved Hide resolved
@consideRatio consideRatio force-pushed the pr/add-changelog-for-2.0.0 branch 2 times, most recently from ba277eb to 603be3f Compare June 27, 2022 16:30
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1 .....

docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
@consideRatio
Copy link
Member Author

@manics ❤️ 🎉 thank you!!!!!!!

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 2

docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
@consideRatio
Copy link
Member Author

consideRatio commented Jul 1, 2022

@manics ❤️ 🎉 🚀 thanks for pushing onwards!!!

Feel free to push commits directly if you want btw!

@manics manics mentioned this pull request Jul 3, 2022
@nreith
Copy link
Contributor

nreith commented Jul 11, 2022

If we want to begin pre-testing the 2.x release while waiting for the last items related to changelogs, where would we find that chart?

@minrk
Copy link
Member

minrk commented Jul 13, 2022

@nreith that would be the latest dev builds here

Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! It seems to me in good shape for a 2.0 beta. What coverage is still missing before we can cut a beta?

docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
#### TODO: link out to relevant informational posts

TODO: Write a discourse forum post about the following and highlight that via
the changelog.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the order for this? Write the post now, then link here, or make a first beta, then write the post, then add link here?

Copy link
Member

@manics manics Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I think getting the beta out first with a short Discourse post linking to the changelog and upgrade guide makes sense and will help speed things up. Save the longer discourse post (and maybe something on the official Jupyter blog) for the final release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#### TODO: link out to relevant informational posts

TODO: Write a discourse forum post about the following and highlight that via
the changelog.

- 100+ user-placeholder pods -> node-placeholder pods
- autohttps acme acquisition issues on GKE mitigation
  (notable-dependencies-200)=

I think it is quite crucial to be aware of that user placeholder pods shouldn't be over 100 or similar, and that there are currently some issues on GKE with slow setup of networking - which causes failures in the autohttps system. But, lets get this out there now instead and hope that we manage to communicate that sometime else instead.

In e8cc8a1 I removed this TODO entry.

docs/source/changelog.md Outdated Show resolved Hide resolved
manics added a commit to manics/zero-to-jupyterhub-k8s that referenced this pull request Jul 14, 2022
@manics
Copy link
Member

manics commented Jul 14, 2022

@consideRatio I've merged in main (to bring in the new upgrade-1-to-2.md guide) and removed the relevant sections from the changelog. I think we should squash all these commits before merging.

docs/source/changelog.md Outdated Show resolved Hide resolved
@manics
Copy link
Member

manics commented Jul 15, 2022

@consideRatio I think I've added all the missing PRs so this should be up to date now.

I've changed the version to 2.0.0-beta.1, this takes some of the pressure associated with a final 2.0.0 release. Do you think this is ready to go?

@manics
Copy link
Member

manics commented Jul 15, 2022

I've rebased and squashed all commits into one here, in case you want to force push it to this PR:
manics@afe5d1d
manics@d01f3d6

Iterative improvements on the changelog 2.0.0 entry

Co-authored-by: Simon Li <orpheus+devel@gmail.com>

docs: use sphinx references instead of hardcoded links

docs: small changelog updates

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

docs: added descriptions of breaking changes

Co-authored-by: Simon Li <orpheus+devel@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Port fixes from changelog to new upgrade guide

Remove breaking/upgrade guide from changelog, link to new guide

Add 2.0.0 notable deps anchor to changelog

Co-authored-by: Min RK <benjaminrk@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Include example of args in singleuser.cmd

Add description of changes to changelog

Co-authored-by: Simon Li <orpheus+devel@gmail.com>

2.0.0-beta.1, with warnings

Update 2.0.0 changelog with more PRs

Update 2.0.0 dependencies table

Remove some backticks which somehow crept in
@manics
Copy link
Member

manics commented Jul 18, 2022

At risk of delaying this further, the next release of JupyterHub requires another DB upgrade, so maybe we should wait?
jupyterhub/jupyterhub#3982

@nreith
Copy link
Contributor

nreith commented Jul 18, 2022

At risk of delaying this further, the next release of JupyterHub requires another DB upgrade, so maybe we should wait? jupyterhub/jupyterhub#3982

To me, this seems a good reason not to delay. Users can get an awesome new version now without having to upgrade the db. Unless I'm misunderstanding.

@manics
Copy link
Member

manics commented Jul 18, 2022

JupyterHub 2 already requires a DB upgrade.

@minrk
Copy link
Member

minrk commented Aug 2, 2022

Yup, JupyterHub 2 has a big, disruptive DB upgrade requiring everything to shutdown and restart. JupyterHub 3 has a db upgrade that z2jh users running the default sqlite shouldn't even notice.

I'm not necessarily opposed to pulling in JupyterHub 3, but if we do that, I'd like to try to focus on reviewing hub 3.0 release PRs. As far as I'm concerned, everything's ready to go but the changelog and I could make a 3.0 beta today: jupyterhub/jupyterhub#3994 . But I don't want to self-merge too much over there.

@minrk
Copy link
Member

minrk commented Aug 2, 2022

What do folks think about testing jupyterhub/chartpress#150 during the 2.0 prerelease cycle? (note: does not need to be picked up before making the first 2.0 beta)

@consideRatio consideRatio changed the title docs: add changelog for 2.0.0 docs: add changelog for 2.0.0 (beta.1) Aug 16, 2022
@consideRatio consideRatio marked this pull request as ready for review August 16, 2022 11:05
@consideRatio
Copy link
Member Author

consideRatio commented Aug 16, 2022

@manics @minrk @sgibson91 - should we go for a release with this? I've updated the PR entries etc so far. The changelog entry can be reviewed in https://zero-to-jupyterhub--2528.org.readthedocs.build/en/2528/changelog.html.

@consideRatio consideRatio merged commit 6fc3d41 into jupyterhub:main Aug 16, 2022
@consideRatio
Copy link
Member Author

Let's go for a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants