Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove unreleased reverted change from 2.0.0 release changelog #2893

Merged
merged 1 commit into from Oct 4, 2022

Conversation

Uular
Copy link
Contributor

@Uular Uular commented Sep 26, 2022

PR #2449 was reverted by #2820 before release, and should not be mentioned in the changelog as a breaking change.

The reversion should be kept in the changelog, as it brought new functionality in addition to reverting the unreleased changes. Added a note referencing the reverted change for posterity. Not sure if the note is in a good spot, feel free to suggest a better place for it.

@welcome
Copy link

welcome bot commented Sep 26, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@yuvipanda yuvipanda merged commit b14c582 into jupyterhub:main Oct 4, 2022
@welcome
Copy link

welcome bot commented Oct 4, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@yuvipanda
Copy link
Collaborator

Thank you very much, @Uular!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants