Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from python 3.9 to 3.11 in hub and singleuser-sample for performance #2919

Merged
merged 1 commit into from Nov 9, 2022

Conversation

yuvipanda
Copy link
Collaborator

@consideRatio
Copy link
Member

consideRatio commented Oct 25, 2022

This build gave us...

#19 17.94 Collecting psycopg2-binary==2.9.4
#19 17.96   Downloading psycopg2-binary-2.9.4.tar.gz (384 kB)

We need 2.9.5. There is py311 builds out now for https://pypi.org/project/psycopg2-binary/2.9.5/#files, but also earlier, so I'm not sure why we got the old version. But, anyhow, we should be able to handle the failure related to use of a postgresql database soon I think by upstream work.

@consideRatio consideRatio temporarily deployed to watch-dependencies November 5, 2022 12:16 Inactive
@consideRatio consideRatio temporarily deployed to watch-dependencies November 5, 2022 12:16 Inactive
@consideRatio consideRatio temporarily deployed to watch-dependencies November 5, 2022 12:16 Inactive
@consideRatio consideRatio temporarily deployed to watch-dependencies November 5, 2022 12:16 Inactive
@consideRatio consideRatio temporarily deployed to watch-dependencies November 5, 2022 12:16 Inactive
@consideRatio consideRatio changed the title Use python 3.11 for hub image Upgrade from python 3.9 to 3.11 in hub and singleuser-sample for performance Nov 5, 2022
@consideRatio
Copy link
Member

@yuvipanda @manics this now works! My main concern for merging is that it is semi-breaking to upgrade the hub pod's python version.

With the hub-slim image pending release, we should go for at least 2.1.0, but should it also be 3.0.0 when changing the python version in the hub image or not? I'm leaning towards 2.1.0 atm.

@manics
Copy link
Member

manics commented Nov 5, 2022

@mathbunnyru made the suggestion of waiting for the first patch release of a new Python version in jupyter/docker-stacks#1812 (comment)

@manics
Copy link
Member

manics commented Nov 5, 2022

I lean towards a major bump when one of Z2JH's dependencies undergoes a significant change that impacts users or admins. There's also a couple of breaking KubeSpawner PRs that could go in https://github.com/jupyterhub/kubespawner/pulls?q=is%3Aopen+is%3Apr+label%3Abreaking

@bjornjorgensen
Copy link

This PR is also upgrading to ubuntu 22.04.
Ubuntu 22.10 is out.

@consideRatio
Copy link
Member

This PR is also upgrading to ubuntu 22.04.
Ubuntu 22.10 is out.

The hub image / singleuser-sample image will keep using debian based images (via python:3.11-slim-bullseye), but what you observe in this PR is a change in the CI system we use, where the testing logic is executed from a Ubuntu 22.04 environment instead of a Ubuntu 20.04 environment. What we choose there won't affect the package helm chart etc.

Note that 20.04 and 22.04 are special "long term support" releases compared to 22.10 which isn't, so that is a reason why you may see those stay around even though 22.10, 23.04, 23.10 arrives later - until 24.04 comes which will be a LTS as well.

@yuvipanda yuvipanda merged commit 06cc6ef into main Nov 9, 2022
@yuvipanda
Copy link
Collaborator Author

I feel ok merging given @consideRatio rewrote most of the PR to actually work hehe :D

Thanks!

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Nov 9, 2022
@consideRatio
Copy link
Member

Thanks @yuvipanda!! :)

Okay 3.0.0 next release, effort needed in kubespawner among other repos first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants