Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satisfy flake8 in jupyterhub_config.py #3065

Merged
merged 1 commit into from Mar 22, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 22, 2023

there shouldn't be any lint config in pre-commit config, because then the same linters run via other means (e.g. editor plugins) will have different results.

Config is unchanged, except for trading the flake8 config to ignore c as a global in favor of defining c explicitly on a single # noqa line.

there shouldn't be any lint config in pre-commit config,
because then linters run via other means (e.g. editor config) will have different results
@consideRatio consideRatio merged commit 88d4bdd into jupyterhub:main Mar 22, 2023
13 checks passed
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Mar 22, 2023
@minrk minrk deleted the declare-lint branch March 22, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants