Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix deprecation of set-output and use ubuntu 22.04 and py311 #3068

Merged

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Mar 24, 2023

@consideRatio consideRatio temporarily deployed to watch-dependencies March 24, 2023 10:14 — with GitHub Actions Inactive
@consideRatio consideRatio temporarily deployed to watch-dependencies March 24, 2023 10:14 — with GitHub Actions Inactive
@consideRatio consideRatio temporarily deployed to watch-dependencies March 24, 2023 10:14 — with GitHub Actions Inactive
@consideRatio consideRatio temporarily deployed to watch-dependencies March 24, 2023 10:14 — with GitHub Actions Inactive
@consideRatio consideRatio temporarily deployed to watch-dependencies March 24, 2023 10:14 — with GitHub Actions Inactive
Comment on lines +54 to +56
repo = "${{ github.repository }}"
event = "${{ github.event_name }}"
ref = "${{ github.event.ref }}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provides a bit more readability when inspecting this, and now that we write to a file based on GITHUB_OUTPUT, this is no longer fine to copy paste this script to run locally anyhow when it previously could be fine to run it locally after having set a few env vars.

@manics manics merged commit 4e7dcc6 into jupyterhub:main Mar 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants