Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of image-awaiter's dockerfile #3078

Merged
merged 1 commit into from Apr 3, 2023
Merged

Refactor of image-awaiter's dockerfile #3078

merged 1 commit into from Apr 3, 2023

Conversation

alekseyolg
Copy link
Contributor

small revision of the dockerfile - removed the extra layer

@alekseyolg
Reducing the number of layers in an image
410b8a0 
small revision of the dockerfile - removed the extra layer
@welcome
Copy link

welcome bot commented Mar 31, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio consideRatio changed the title Reducing the number of layers in an image Refactor of image-awaiter's dockerfile Apr 3, 2023
consideRatio
consideRatio approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are in the build stage of this Dockerfile and shouldn't infleunce the final stage that starts from scratch, but its a simplification so lets go for it!

Thank you @alekseyolg!!! ❤️ 🎉 🌻

@consideRatio consideRatio merged commit dec9fad into jupyterhub:main Apr 3, 2023
16 checks passed
@welcome
Copy link

welcome bot commented Apr 3, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Apr 3, 2023
[jupyterhub] Automatic update for commit 2.0.1-0.dev.git.6110.hdec9fad9
83d74d7 
jupyterhub/zero-to-jupyterhub-k8s#3078 Merge pull request #3078 from alekseyolg/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alekseyolg @consideRatio