Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.0.0-0.dev #3084

Merged
merged 2 commits into from Apr 5, 2023
Merged

Bump to 3.0.0-0.dev #3084

merged 2 commits into from Apr 5, 2023

Conversation

yuvipanda
Copy link
Collaborator

We're already on JupyterHub 4.x, so this
makes sense from a semver perspective. Useful
in generating better versions in https://hub.jupyter.org/helm-chart/.

Credit to @pnasrat for pointing this out.

We're already on JupyterHub 4.x, so this 
makes sense from a semver perspective. Useful
in generating better versions in https://hub.jupyter.org/helm-chart/.

Credit to @pnasrat for pointing this out.
@yuvipanda
Copy link
Collaborator Author

Even if we are not on JupyterHub 4.x, bumping to next version.dev after each release makes sense, and we do that for our other projects.

@consideRatio consideRatio changed the title Bump to 3.0.0dev Bump to 3.0.0-0.dev Apr 4, 2023
@consideRatio
Copy link
Member

I think the test failures are intermittent, I'll re-run the tests later!

@consideRatio
Copy link
Member

I figure the pattern should be to bump baseVersion to next minor with -0.dev suffix if we have merged a new feature, or next major with -0.dev suffix if we have merged a breaking change.

@yuvipanda
Copy link
Collaborator Author

@consideRatio yep makes sense re: pattern. Should we document that someplace?

@consideRatio
Copy link
Member

consideRatio commented Apr 4, 2023

@consideRatio yep makes sense re: pattern. Should we document that someplace?

I figure it belongs as a comment in chartpress.yaml next to baseVersion and possibly someplace if read by maintainers who merges PRs. I figure its mainly something maintainers merging PRs should be aware of, maybe the contributing docs?

I figure if its documented in only one place I'd value the inline comment in chartpress.yaml the msot, and if in multiple places also in contributing docs.

UPDATE: Added c0d0b3b to document this as an inline comment in chartpress.yaml.

@consideRatio
Copy link
Member

Thank you @pnasrat and @yuvipanda!!

@consideRatio consideRatio merged commit c73de93 into main Apr 5, 2023
27 of 28 checks passed
@consideRatio consideRatio deleted the yuvipanda-patch-2 branch April 5, 2023 14:10
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants