New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 3.0.0-0.dev #3084
Bump to 3.0.0-0.dev #3084
Conversation
We're already on JupyterHub 4.x, so this makes sense from a semver perspective. Useful in generating better versions in https://hub.jupyter.org/helm-chart/. Credit to @pnasrat for pointing this out.
Even if we are not on JupyterHub 4.x, bumping to next version.dev after each release makes sense, and we do that for our other projects. |
I think the test failures are intermittent, I'll re-run the tests later! |
I figure the pattern should be to bump baseVersion to next minor with |
@consideRatio yep makes sense re: pattern. Should we document that someplace? |
I figure it belongs as a comment in chartpress.yaml next to baseVersion and possibly someplace if read by maintainers who merges PRs. I figure its mainly something maintainers merging PRs should be aware of, maybe the contributing docs? I figure if its documented in only one place I'd value the inline comment in chartpress.yaml the msot, and if in multiple places also in contributing docs. UPDATE: Added c0d0b3b to document this as an inline comment in chartpress.yaml. |
Thank you @pnasrat and @yuvipanda!! |
jupyterhub/zero-to-jupyterhub-k8s#3084 Merge pull request #3084 from jupyterhub/yuvipanda-patch-2
We're already on JupyterHub 4.x, so this
makes sense from a semver perspective. Useful
in generating better versions in https://hub.jupyter.org/helm-chart/.
Credit to @pnasrat for pointing this out.