Allow enabled config, for use by charts depending on this chart conditionally
#3162
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
| @@ -3,6 +3,9 @@ | |||
| fullnameOverride: "" | |||
| nameOverride: | |||
|
|
|||
| # enable or disable jupyterhub if it is included as a dependency in a parent helm chart | |||
| enabled: | |||
There was a problem hiding this comment.
What do other charts typically do? Do they leave this null, or default to true?
There was a problem hiding this comment.
I suggest its made null as default here, true/false has no meaning by this chart anyhow so making it null seems less confusing, and both false/true and can be defaults for a chart depending on this - such chart should define enabled to false/true explicitly.
There was a problem hiding this comment.
Most charts dont need an entry for this, but we have a strict schema.
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
There was a problem hiding this comment.
Thanks @monoakg!!
From experience and examples from helm's documentation, its clear that enabled indeed is the common naming choice for this.
I've updated the language to make it really clear that this is a feature implemented in a chart conditionally depending on this chart
consideRatio
changed the title
enabled as key in values.yamlenabled config, for use by charts depending on this chart conditionally
|
Congrats on your first merged pull request in this project! 🎉 |
jupyterhub/zero-to-jupyterhub-k8s#3162 Merge pull request #3162 from monoakg/feature/allow-enabled-in-values-yaml
Linked issue #3160 - Update values schema to allow key
enabledCloses #3160