Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for kube-lego (https certificates) #3186

Merged
merged 1 commit into from Aug 4, 2023

Conversation

Ph0tonic
Copy link
Contributor

@Ph0tonic Ph0tonic commented Aug 4, 2023

Add a deprecation warning message for the section about kube-lego as it has been deprecated in favor of cert-manager.

Add a deprecation warning message for the section about `kube-lego` as it has been deprecated in favor of `cert-manager`.
@welcome
Copy link

welcome bot commented Aug 4, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Ph0tonic Ph0tonic closed this Aug 4, 2023
@Ph0tonic Ph0tonic deleted the Ph0tonic-patch-1 branch August 4, 2023 07:37
@Ph0tonic Ph0tonic restored the Ph0tonic-patch-1 branch August 4, 2023 07:37
@Ph0tonic Ph0tonic reopened this Aug 4, 2023
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is a very outdated documentation section, I think nobody should be recommended towards kube-lego helm chart. Use of cert-manager works great though.

@consideRatio consideRatio merged commit 3057f9c into jupyterhub:main Aug 4, 2023
5 checks passed
@welcome
Copy link

welcome bot commented Aug 4, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@consideRatio
Copy link
Member

Thank you @Ph0tonic!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants