Fix previously ignored revisionHistoryLimit config

[SchutteJan]

Sometimes Helm reports type float64 for integer numbers set in values.yaml. See this Helm issue for an example:
helm/helm#4982

This fix replaces the type check with a simple check + integer cast.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[consideRatio]

We should be able to set this to 0 as well, and that was the point of having the typeIs check. We could also change this check to a "not null" check since we have a schema for the helm chart enforcing that makes it either null or int.

Do you have an example reproduction of the bug you look to fix with this change?

[SchutteJan]

Good point, forgot that 0 was treated as a false in this case. I've changed the check to check for not-nil.

Setting the following value file will not render the revisionLimitHistory in the chart:

hub:
  revisionHistoryLimit: 1

This is on helm version:

version.BuildInfo{Version:"v3.14.2", GitCommit:"c309b6f0ff63856811846ce18f3bdc93d2b4d54b", GitTreeState:"clean", GoVersion:"go1.21.7"}

[consideRatio]

Nice catch @SchutteJan! I could reproduce the issue and concluded that this PR fixes it!

Reproduction steps I took:

tools/generate-json-schema.py
# manually update jupyterhub/values.yaml to provide various defaults for hub.revisionHistoryLimit
helm template jupyterhub --show-only templates/hub/deployment.yaml | grep revision

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[consideRatio]

I also verified this was fixing the issue in all places, and that there wasn't any other issues related to using typeIs "int" checks on integers.

Thank you @SchutteJan! ❤️ 🎉 🌻