Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentication github org clarification #686

Merged
merged 1 commit into from May 16, 2018

Conversation

choldgraf
Copy link
Member

closes #684

@rsignell-usgs what do you think?

@betatim betatim merged commit 016c33d into jupyterhub:master May 16, 2018
@betatim
Copy link
Member

betatim commented May 16, 2018

Merged, if we need to we can make a new PR to adjust things further.

@rsignell-usgs
Copy link
Contributor

rsignell-usgs commented May 16, 2018

@choldgraf , this clarification is good, but I'm wondering why were were getting 403 errors when people's group status was set to private, as we did have auth.scopes set to read.org.

I'm raising this issue here: #687

Does this statement:

Changing auth.scopes will not change the scope for existing OAuth tokens, you must invalidate them.

mean that the JuptyerHub oath app client secret needs to be reset or user tokens revoked on github?

@minrk
Copy link
Member

minrk commented May 16, 2018

the JuptyerHub oath app client secret needs to be reset or user tokens revoked on github?

Yes, the tokens must be revoked. I believe GitHub has a "revoke all tokens" button for a given oauth application. That's probably what you want.

@choldgraf
Copy link
Member Author

hmmm, that's a good question. Could you open a new issue and copy/paste the message above so we don't lose track of it? (since this issue is closed)

@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

403 errors with github auth whitelist
5 participants