Check the extension of extracted file for backward matching #65
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollonval
reviewed
Sep 10, 2021
There was a problem hiding this comment.
Thanks a lot for pushing quickly a PR. Are you familiar with pytest? Could you add a test for this?
Some pointers:
The test for extracting an archive is there: https://github.com/aidy1991/jupyter-archive/blob/0516701ac7aed0640d2f78f6f9f2e5ff91b51d65/jupyter_archive/tests/test_archive_handler.py#L128
I advice you to update that test by adding a another pytest.mark.parametrize that set the archive name (see that test for an example of a double parametrized loops).
|
Thank you for very quick review and merging!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #63
I have modified it to check the extension of extracted file for backward matching.