New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suffix check for archive extraction #66
Fix suffix check for archive extraction #66
Conversation
Thanks for testing that quickly. Could you also add test for this? |
Would it be better to add a new test case (test function) to test that it fails with a file name like |
I would add a new |
Thank you for you advice! I'll try to add it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test. I left one suggestion and a question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @aidy1991 to quickly react on the comments.
Thank you for your review!! |
Ref #65
Sorry, I noticed that implementation of #65 allows invalid file name like
hoge.aazip
because we check extension by backward matching and compared extension does not include.
.This PR will resolve this problem.