Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id in TourManager.addTour #27

Closed
fcollonval opened this issue May 19, 2021 · 0 comments · Fixed by #28
Closed

Fix id in TourManager.addTour #27

fcollonval opened this issue May 19, 2021 · 0 comments · Fixed by #28
Assignees
@fcollonval

Comments

@fcollonval
Copy link
Member

Oops, looks like this maybe shouldn't have snuck in here?

Originally posted by @bollwyvl in #24 (comment)
@fcollonval fcollonval self-assigned this May 19, 2021
fcollonval added a commit that referenced this issue May 19, 2021
@fcollonval
Fix id in TourManager.addTour
ee4ce52 
Fixes #27
@fcollonval fcollonval mentioned this issue May 19, 2021
Merged
fcollonval added a commit that referenced this issue May 23, 2021
@fcollonval
Fix id in TourManager.addTour (#28)
a527e1d 
* Fix id in `TourManager.addTour`
Fixes #27

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcollonval fcollonval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix id in TourManager.addTour jupyterlab-contrib/jupyterlab-tour
1 participant
@fcollonval