Support translation #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks Frédéric! |
|
Looks like there is a small conflict. |
fcollonval
force-pushed
the
fcollonval/issue16
branch
from
57163e6
to
4deb14e
Compare
bollwyvl
reviewed
May 19, 2021
| } | ||
|
|
||
| const handler = this.createTour( | ||
| `${USER_PLUGIN_ID}:${tour.id}`, |
There was a problem hiding this comment.
Oops, looks like this maybe shouldn't have snuck in here?
There was a problem hiding this comment.
Oh yes, thanks for catching it. I'll push a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
cc @jtpio