Skip to content

Commit

Permalink
Set more meaningful reference (#113)
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed Aug 23, 2022
1 parent 7c15f45 commit dc12019
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/run-benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ jobs:
- name: Execute benchmark tests
continue-on-error: true
working-directory: benchmarks/tests
env:
BENCHMARK_REFERENCE: ${{ inputs.event == 'schedule' && 'expected' || inputs.reference_branch }}
run: |
set -ex
# Update test screenshots
Expand Down Expand Up @@ -253,6 +255,8 @@ jobs:
- name: Execute benchmark tests
continue-on-error: true
shell: bash
env:
BENCHMARK_REFERENCE: ${{ inputs.event == 'schedule' && 'actual' || env.CHALLENGER_REF }}
run: |
set -ex
# Update test screenshots
Expand All @@ -275,7 +279,7 @@ jobs:
# Publish image to cml.dev
echo "" >> ${REPORT}
cml-publish ./benchmark-results/lab-benchmark.svg --md >> ${REPORT} || true
echo "Expected = [${{ env.OLD_REF_SHA }}](https://github.com/jupyterlab/jupyterlab/commit/${{ env.OLD_REF_SHA }}) | Actual = [${{ env.NEW_REF_SHA }}](https://github.com/${{ env.CHALLENGER_REPOSITORY }}/commit/${{ env.NEW_REF_SHA }})" >> ${REPORT}
echo "${{ inputs.event == 'schedule' && 'Expected' || inputs.reference_branch }} = [${{ env.OLD_REF_SHA }}](https://github.com/jupyterlab/jupyterlab/commit/${{ env.OLD_REF_SHA }}) | ${{ inputs.event == 'schedule' && 'Actual' || env.CHALLENGER_REF }} = [${{ env.NEW_REF_SHA }}](https://github.com/${{ env.CHALLENGER_REPOSITORY }}/commit/${{ env.NEW_REF_SHA }})" >> ${REPORT}
echo "[Go to action log](https://github.com/jupyterlab/benchmarks/actions/runs/${{ github.run_id }})" >> ${REPORT}
if [[ "${{ env.CHALLENGER_REPOSITORY }}" == "jupyterlab/jupyterlab" ]]; then
echo "[Changelog covered](https://github.com/jupyterlab/jupyterlab/compare/${{ env.OLD_REF_SHA }}...${{ env.NEW_REF_SHA }})" >> ${REPORT}
Expand Down

0 comments on commit dc12019

Please sign in to comment.