Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Various fixes to the variables main area panel #397

Merged
merged 5 commits into from
Mar 17, 2020
Merged

Various fixes to the variables main area panel #397

merged 5 commits into from
Mar 17, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 16, 2020

Replaces #396.

Changes

  • Filter applies to the top-level variables only
  • Make the table scrollable
  • Use consistent naming for VariableDetails (code style)

@jtpio jtpio mentioned this pull request Mar 16, 2020
Closed
@jtpio jtpio marked this pull request as ready for review March 16, 2020 15:12
afshin
afshin approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afshin afshin merged commit 92d8690 into jupyterlab:master Mar 17, 2020
@jtpio jtpio deleted the variables-panel branch July 20, 2020 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @afshin