Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing #137

Closed
jtpio opened this issue Jan 26, 2021 · 0 comments · Fixed by #207
Closed

Add testing #137

jtpio opened this issue Jan 26, 2021 · 0 comments · Fixed by #207
Assignees

Comments

@jtpio
Copy link
Member

jtpio commented Jan 26, 2021

It would be nice to add the structure for unit tests with jest to this cookiecutter by default.

This would let extension authors quickly get started with testing, as it often requires knowing what dependencies to include and what structure to follow (currently documented in https://jupyterlab.readthedocs.io/en/stable/extension/extension_dev.html?#testing-your-extension).

Additionally there could also be end to end tests (for example with galata, although this might require the cookiecutter to do a bit more than logging with console.log.

@fcollonval fcollonval self-assigned this Feb 12, 2022
fcollonval added a commit to fcollonval/extension-cookiecutter-ts that referenced this issue Feb 12, 2022
3coins pushed a commit to 3coins/extension-cookiecutter-ts that referenced this issue May 28, 2022
fcollonval added a commit that referenced this issue Jun 4, 2022
* Add jest and playwright testing
Fixes #137

* Fix working directory

* Use Jest 26

* Don't lint tests files

* Fix manifest

* Add update snapshots action

* Add documentation

* Add pytest

* Fix cookiecutter

* Print log and stop jupyter lab

* First install jupyter lab

* partial revert to test stuck CI task

* Fix pytest

* Ensure server log redirection

* Move ui tests config in subfolder

* Add documentation for pytest

* Run integration tests in post job using distribution artifact

* Apply review suggestions
- Handle server spin up in Playwright config
- Cache browser download
- Use one artifact
- Don't constrain explicitly Python

* Update check test

* [skip ci] Update documentation

* Remove galata and playwright from main package.json

* Update galata

* Add jest and playwright testing
Fixes #137

* Fix working directory

* Use Jest 26

* Don't lint tests files

* Fix manifest

* Add update snapshots action

* Add documentation

* Add pytest

* Fix cookiecutter

* Print log and stop jupyter lab

* First install jupyter lab

* partial revert to test stuck CI task

* Fix pytest

* Ensure server log redirection

* Move ui tests config in subfolder

* Add documentation for pytest

* Run integration tests in post job using distribution artifact

* Apply review suggestions
- Handle server spin up in Playwright config
- Cache browser download
- Use one artifact
- Don't constrain explicitly Python

* Update check test

* [skip ci] Update documentation

* Remove galata and playwright from main package.json

* Update galata

* Fixed rebase

* Fix prettier

* Fix mac job

* Apply suggestions

* Add configurable for setting up the tests

* Fix syntax

* Fix for new cookiecutter

* Minor fixes

* Conditioned type jest

Co-authored-by: 3coins <pyjain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants