Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate theme cookiecutter #196

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Conversation

fcollonval
Copy link
Member

To reduce maintenance burden this merge https://github.com/jupyterlab/theme-cookiecutter

The cookiecutter variables have been changed to first request the type of extension using a enumeration: frontend, server or theme.

@fcollonval fcollonval marked this pull request as ready for review January 13, 2022 12:16
@fcollonval fcollonval requested a review from jtpio January 13, 2022 12:16
@jtpio
Copy link
Member

jtpio commented Jan 13, 2022

Thanks!

To reduce maintenance burden this merge https://github.com/jupyterlab/theme-cookiecutter

+1, since the theme cookiecutter can easily get out of sync and doesn't necessarily benefit from the improvements made to the ts cookiecutter here (for example CI and releaser config).

Some follow-up steps that come to mind:

@fcollonval
Copy link
Member Author

@jtpio would it be ok to move forward with this?

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jtpio jtpio merged commit be2dd2e into jupyterlab:3.0 Jan 21, 2022
@jtpio
Copy link
Member

jtpio commented Jan 21, 2022

Some follow-up steps that come to mind:

Let's open the corresponding issues to keep track of these steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants