Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Update the cookiecutter for JupyterLab 4 and Notebook 7 #234

Merged
merged 11 commits into from
Oct 6, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 4, 2022

Fixes #231

The motivation is to be able to start creating extensions for JupyterLab 4 and Notebook 7 directly using this cookiecutter:

cookiecutter https://github.com/jupyterlab/extension-cookiecutter-ts --checkout 4.0

@jtpio jtpio marked this pull request as draft October 4, 2022 12:11
@jtpio jtpio changed the title [4.0] Update the cookiecutter for JupyterLab 4 [4.0] Update the cookiecutter for JupyterLab 4 and Notebook 7 Oct 4, 2022
@jtpio jtpio marked this pull request as ready for review October 4, 2022 12:59
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor suggestion. Otherwise it looks good; thanks for this one @jtpio

{{cookiecutter.python_name}}/binder/environment.yml Outdated Show resolved Hide resolved
jtpio and others added 2 commits October 6, 2022 17:44
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@jtpio
Copy link
Member Author

jtpio commented Oct 6, 2022

Thanks @fcollonval for the review. I applied the suggestion and also update the Python version used on Binder.

@jtpio jtpio merged commit 8096c5a into jupyterlab:4.0 Oct 6, 2022
@jtpio jtpio deleted the update-lab-4 branch October 6, 2022 17:23
@jtpio jtpio mentioned this pull request Oct 6, 2022
@jtpio jtpio mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants