Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an opt-in binder #64

Merged
merged 2 commits into from
May 18, 2020
Merged

Add an opt-in binder #64

merged 2 commits into from
May 18, 2020

Conversation

bollwyvl
Copy link
Contributor

While having GitHub CI is cool, demos are even cooler for getting people spun up and experiencing shareable success quickly.

This adds an opt-in has_binder switch which will create a fairly-opinionated binder (or local) environment based on a binder folder with:

  • an environment.yml
    • because binder is already conda-based, and will predictably work on windows
      • and pinning node/lab versions is a Good Thing
  • a python-based postBuild
    • because bash is scary, see point above about windows
  • a simple labextensions.txt with the extension-under-demo as well as some recommendations
    • because we don't have a "real" file description

Also further populated badgeopolis in the README.

I haven't added anything to the tests... maybe should be black/flake8 checking output python, but otherwise there's no code added.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one nit

@@ -1,6 +1,9 @@
# {{ cookiecutter.extension_name }}

![Github Actions Status]({{ cookiecutter.repository }}/workflows/Build/badge.svg)
{%- if cookiecutter.has_binder.lower().startswith('y') -%}
[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/{{ cookiecutter.repository|replace("https://github.com/", "") }}/master)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a ?urlpath=lab

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 66595f9

@blink1073
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants