Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Allow for custom tab bar ids #46

Closed
jtpio opened this issue Jun 8, 2021 · 1 comment · Fixed by #48
Closed

Allow for custom tab bar ids #46

jtpio opened this issue Jun 8, 2021 · 1 comment · Fixed by #48
Assignees
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Jun 8, 2021

Problem

For now the set of tab bar ids is defined here:

type SidebarTabId = 'filebrowser' | 'jp-running-sessions' | 'tab-manager' | 'jp-property-inspector' | 'table-of-contents' | 'extensionmanager.main-view' | 'jp-debugger-sidebar';

It would be great if this could be made configurable, or be able to pass any id.

For example the @jupyterlab/git extension adds a panel to the left area, and this extension could use galata for end to end testing.

Proposed Solution

Allow arbitrary ids (as strings)?

Additional context

Related to #45

@jtpio jtpio added the enhancement New feature or request label Jun 8, 2021
@jtpio
Copy link
Member Author

jtpio commented Jun 8, 2021

There might actually be other parts that could be made more customizable, to make it easier to use galata for third-party extension testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants