-
-
Notifications
You must be signed in to change notification settings - Fork 15
Allow for custom tab bar and nb toolbar item ids #48
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Thanks! Regarding the whitespaces, maybe we could do a pass on the codebase to format all at once, and adopt prettier? In the meantime we can check the diff for this PR without the whitespaces with: https://github.com/jupyterlab/galata/pull/48/files?diff=split&w=1 |
I think prettier will make sense to be consistent with JLab. ... sorry I have turn on auto format on save so this brings noise when no linter is set like here. |
Maybe we can then do that together with #49 first. |
7616800
to
36db591
Compare
This has been rebased. |
Thanks! This should give more flexibility to third-party extension authors. |
36db591
to
af62619
Compare
Small note: in VS Code the LS solves the type to simple string. Hence code hint is not showing the default value but simply type: string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #46