Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Allow for custom tab bar and nb toolbar item ids #48

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

fcollonval
Copy link
Member

Fixes #46

@welcome
Copy link

welcome bot commented Jun 9, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtpio
Copy link
Member

jtpio commented Jun 9, 2021

Thanks!

Regarding the whitespaces, maybe we could do a pass on the codebase to format all at once, and adopt prettier?

In the meantime we can check the diff for this PR without the whitespaces with: https://github.com/jupyterlab/galata/pull/48/files?diff=split&w=1

@fcollonval
Copy link
Member Author

maybe we could do a pass on the codebase to format all at once, and adopt prettier?

I think prettier will make sense to be consistent with JLab.

... sorry I have turn on auto format on save so this brings noise when no linter is set like here.

@jtpio
Copy link
Member

jtpio commented Jun 9, 2021

I think prettier will make sense to be consistent with JLab.

Maybe we can then do that together with #49 first.

@fcollonval
Copy link
Member Author

This has been rebased.

@fcollonval fcollonval self-assigned this Jun 11, 2021
@fcollonval fcollonval requested a review from jtpio June 12, 2021 07:41
@jtpio
Copy link
Member

jtpio commented Jun 12, 2021

Thanks!

This should give more flexibility to third-party extension authors.

@fcollonval
Copy link
Member Author

Small note: in VS Code the LS solves the type to simple string. Hence code hint is not showing the default value but simply type: string.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 8a72a43 into jupyterlab:main Jun 14, 2021
@fcollonval fcollonval deleted the fcollonval/issue46 branch June 14, 2021 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for custom tab bar ids
2 participants