Fix settings update and vertical scroll (#249)

* Fix for propagating provider param updates

* Adds vertical scroll for settings panel

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

packages/jupyter-ai/jupyter_ai/actors/base.py

@@ -88,14 +88,18 @@ def get_llm_chain(self):
             else None
         )
 
-        if not lm_provider:
+        if not lm_provider or not lm_provider_params:
             return None
 
         if curr_lm_id != next_lm_id:
             self.log.info(
                 f"Switching chat language model from {curr_lm_id} to {next_lm_id}."
             )
             self.create_llm_chain(lm_provider, lm_provider_params)
+        elif self.llm_params != lm_provider_params:
+            self.log.info("Chat model params changed, updating the llm chain.")
+            self.create_llm_chain(lm_provider, lm_provider_params)
+
         return self.llm_chain
 
     def get_embeddings(self):
@@ -104,10 +108,13 @@ def get_embeddings(self):
         embedding_params = ray.get(actor.get_provider_params.remote())
         embedding_model_id = ray.get(actor.get_model_id.remote())
 
-        if not provider:
+        if not provider or not embedding_params:
             return None
 
-        if embedding_model_id != self.embedding_model_id:
+        if (
+            embedding_model_id != self.embedding_model_id
+            or self.embeddings_params != embedding_params
+        ):
             self.embeddings = provider(**embedding_params)
 
         return self.embeddings

packages/jupyter-ai/src/components/chat-settings.tsx

@@ -289,7 +289,8 @@ export function ChatSettings(): JSX.Element {
       sx={{
         padding: 4,
         boxSizing: 'border-box',
-        '& > .MuiAlert-root': { marginBottom: 2 }
+        '& > .MuiAlert-root': { marginBottom: 2 },
+        overflowY: 'auto'
       }}
     >
       {state === ChatSettingsState.SubmitError && (