Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings update and vertical scroll #249

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Jun 30, 2023

Fixes #248
Fixes #247

@3coins 3coins added the bug Something isn't working label Jun 30, 2023
@3coins 3coins self-assigned this Jun 30, 2023
@3coins 3coins added this to the 0.9.0 Release milestone Jun 30, 2023
@3coins 3coins marked this pull request as ready for review June 30, 2023 03:52
@dlqqq
Copy link
Collaborator

dlqqq commented Jun 30, 2023

Can we hold off on merging this until #244 is merged, since we intend to include both in the same release?

@3coins
Copy link
Collaborator Author

3coins commented Jun 30, 2023

@dlqqq
#244 is a huge change and not ready to be merged. This a very small change and fixes working of settings panel especially with SM endpoints. Ideally, I would like to do a patch release for this ASAP.

@JasonWeill JasonWeill removed this from the 0.9.0 Release milestone Jun 30, 2023
@JasonWeill
Copy link
Collaborator

Per standup, we decided to defer #244 to 0.10.0, so this is unblocked for 0.9.0.

@JasonWeill JasonWeill merged commit f4389f6 into jupyterlab:main Jul 5, 2023
5 of 6 checks passed
@dlqqq dlqqq mentioned this pull request Jul 5, 2023
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* Fix for propagating provider param updates

* Adds vertical scroll for settings panel

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants