Avoids using str.removeprefix and str.removesuffix #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
approved these changes
May 14, 2023
|
Let's hold off on merging this though; it would be nice to have a CI workflow that captures this failure to make sure we never introduce a regression that breaks py38 again. |
JasonWeill
changed the title
JasonWeill
force-pushed
the
python-3-8-compat
branch
from
017c88f
to
801f635
Compare
dlqqq
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
str.removeprefixandstr.removesuffix, which are not available in Python 3.8, with a regular expression to remove initial commas from output. Fixes #167.