Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify/fix conda instructions #547

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

krassowski
Copy link
Member

Fixes #542

Users here and elsewhere (e.g. gitter channel) complained that the short instructions in readme are not working and not friendly for a newbie. Two issues were mentioned:

  • copy-pasting conda instructions does not work because conda-forge channel is not mentioned
  • for users new to Python ecosystem it is not obvious that they should either use the pip or conda route (despite the headings suggesting that indirectly)

This PR attempts to address both issues.

@krassowski krassowski added the documentation Improvements or additions to documentation label Dec 27, 2023
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Just left a few formatting fixes for you.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dlqqq
Copy link
Collaborator

dlqqq commented Dec 27, 2023

(btw, I still am working on the autocomplete branch. I have to wrap up #546 and also rebase autocomplete on main later)

Co-authored-by: david qiu <david@qiu.dev>
@dlqqq dlqqq enabled auto-merge (squash) December 27, 2023 22:22
@dlqqq dlqqq merged commit def73e9 into jupyterlab:main Dec 27, 2023
8 checks passed
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* Clarify/fix conda instructions

* Apply suggestions from code review

Co-authored-by: david qiu <david@qiu.dev>

---------

Co-authored-by: david qiu <david@qiu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda install fails
2 participants