Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error when allowed or blocked model list is passed in config #855

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Jun 22, 2024

Fixes #815

@3coins 3coins added the bug Something isn't working label Jun 22, 2024
@3coins 3coins marked this pull request as ready for review June 22, 2024 01:15
@3coins 3coins requested review from dlqqq and krassowski and removed request for dlqqq June 22, 2024 01:16
packages/jupyter-ai/jupyter_ai/handlers.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the error when allowed or blocked model list is passed in config in v2.18.1. Current version of the PR looks good, it fixes the error and implements @dlqqq's change request #855 (comment).

@3coins 3coins merged commit cee178b into jupyterlab:main Jun 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providing allowed models in the config breaks settings UI
3 participants