Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes error when allowed or blocked model list is passed in config #855

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fixes error when allowed or blocked model list is passed in config #855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb7508
Fixes error when allowed or blocked model list is passed in config.
3coins Jun 22, 2024
8c09906
Simplified null check.
3coins Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/jupyter-ai/jupyter_ai/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,12 @@ def filter_predicate(local_model_id: str):

# filter out every model w/ model ID according to allow/blocklist
for provider in providers:
provider.models = list(filter(filter_predicate, provider.models))
provider.chat_models = list(filter(filter_predicate, provider.chat_models))
provider.models = list(filter(filter_predicate, provider.models or []))
provider.chat_models = list(
filter(filter_predicate, provider.chat_models or [])
)
provider.completion_models = list(
filter(filter_predicate, provider.completion_models)
filter(filter_predicate, provider.completion_models or [])
)

# filter out every provider with no models which satisfy the allow/blocklist, then return
Expand Down
Loading