Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of a MathJax 3 (prerelease) extension. #69

Merged
merged 21 commits into from
Aug 2, 2018

Conversation

jasongrout
Copy link
Contributor

Don't merge yet - this doesn't work yet.

@ian-r-rose
Copy link
Member

I have pushed workarounds for mathjax/MathJax-src#68 and mathjax/MathJax-src#69. I suspect that neither of these are intended behavior.

This is still not quite working, as I have not figured out how to have webpack pick up the MathJax fonts in mathjax2/css. Ideas?

@jasongrout
Copy link
Contributor Author

Latest commit seems to get things to render okay, but the font location is hardcoded, so it doesn't look that great. Since we can't directly influence the jlab webpack config, we can't put in the appropriate webpack redirections to handle the hardcoded fonts, so we'll have to wait on that one.

@ian-r-rose
Copy link
Member

What made the setting of the document unnecessary?

@jasongrout
Copy link
Contributor Author

jasongrout commented Nov 18, 2017 via email

@jasongrout
Copy link
Contributor Author

The fonts issue has had some work in MathJax, so I think it's ready to tackle getting the fonts to load again. See mathjax/MathJax-src#70 (comment)

@ian-r-rose
Copy link
Member

ian-r-rose commented Dec 30, 2017

@jasongrout This is now working, with the caveat that we need to update the JupyterLab webpack config to pick up .otf fonts, which is used in one of the typefaces.
Update: The webpack issue is now fixed in master (jupyterlab/jupyterlab#3500)

@ian-r-rose
Copy link
Member

ian-r-rose commented Dec 30, 2017

I am seeing some errors with the parsing of HTML, but I think those might be MathJax3 bugs.
cf. mathjax/MathJax-src#78

@ian-r-rose
Copy link
Member

@jasongrout I've been keeping this more-or-less up to date. Now mathjax3 is in beta, and some of the rendering bugs we saw in earlier versions have been ironed out. I think this is probably ready to merge and publish.

@jasongrout jasongrout changed the title WIP Initial version of a MathJax 3 (alpha) extension. Initial version of a MathJax 3 (prerelease) extension. Aug 2, 2018
@blink1073
Copy link
Member

👍

@ian-r-rose ian-r-rose merged commit 9b1a199 into jupyterlab:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants