Simple Auth support

[ktaletsk]

Adds simple credentials support as requested in #299

User flow

1. User initiate git operation that may require auth (clone/push/pull)
2. Extension attempts to clone/push/pull without credentials (assuming user set up their own SSH keys) is done exactly as before
3. If git returns an error indicating insufficient credentials, extension shows a credential form for git username and password. User credentials are collected and sent to the backend.
   3a. If wrong credentials are provided form is shown over and over until successful authentication / or until user clicks 'CANCEL' button on the credentials form.

If user sets their own credentials, step 3 never happen.
When cloning/pulling from public repo, step 3 never happen

Technical details
On the backend, API handler is overloaded to expect auth information. Git class methods clone, push and pull are updated to allow passing of username/password information to git CLI using pexpect library similar to how subprocess.Popen is used to do that without credentials.

On the frontend, couple of new forms are added. src/components/CredentialsBox.tsx implements the body of credentials dialog. src/components/CommitAuthorBox.tsx implements similar dialog, but for author information on git commit.

Comments
UI is still little rough around the edges, but I hope community can help me fix that.

[saulshanabrook]

I tried this out locally and it worked for me. I am going to give a longer review of the code as well.

[brunowego]

Hi @ktaletsk, thanks for this, I'm looking exactly for this!

[ktaletsk]

@saulshanabrook, is there any update on this PR? Do you have any questions regarding proposed changes? I would rebase to the latest 0.6.0, but I need to know if this PR will be considered.

[saulshanabrook]

Sorry for the delay on this, thank you for contributing this feature! It looks good to me.

[ktaletsk]

I am going to resolve all the current conflicts with master shortly

[jaipreet-s]

But I am still unclear, can't we include the auth support without this extract logic around the name and email? And just assume people have already set that up globally?

I don't think this question from Saul was addressed, and I have the same question.

[ktaletsk]

Per @saulshanabrook,

I think this looks fine as is. We can always move it to setting the global later.

Should I take commit author attribution out of this Auth PR and submit as a separate PR?

[saulshanabrook]

Should I take commit author attribution out of this Auth PR and submit as a separate PR?

That would be ideal, but I understand it's more work for you. I am OK taking this as is, but @jaipreet-s would you prefer them to be split?

[ktaletsk]

@saulshanabrook @jaipreet-s I removed my implementation of the identity feature as it was added by #366. I also rebased to the latest master. Please, take a look.

[ktaletsk]

Thank you @fcollonval for the review and useful suggestions. I addressed the issues in the latest commit.

[fcollonval]

Thx @ktaletsk
This is a great addition!

[fcollonval]

@ktaletsk I forgot to point out, you need to add pexpect in setup.py

jupyterlab-git/setup.py

Lines 17 to 20 in 0b4339f

	install_requires=[
	'notebook',
	'nbdime >= 1.1.0'
	],

@jaipreet-s @saulshanabrook I think this is now ready to be merged. Could you please have a look?

[jaipreet-s]

Thanks @ktaletsk for this work! I'll attempt to take a look sometime next week.

[jaipreet-s]

Thanks for the contribution! I have some feedback but once that is addressed it would be great to have this feature merged in :-)

[ktaletsk]

@jaipreet-s @fcollonval I went through the latest review, but I couldn't find a way to make the username and password required fields. Do you have any suggestions how to implement that?

[fcollonval]

@ktaletsk Could you please rebase your branch on the master to solve the conflicts?

[ktaletsk]

@fcollonval rebased! Let's merge it

[fcollonval]

Thx a lot @ktaletsk especially for your patience to bring it through all the comments.

Changes have been taken into account

[ktaletsk]

Thanks @fcollonval @jaipreet-s @saulshanabrook and everyone who participated in discussions. Feels great to contribute to this extension!

[jaipreet-s]

👍

[sudeshgit]

In which release this change is going to be included? I can see 0.8.1 as latest (https://pypi.org/project/jupyterlab-git/)

[fcollonval]

There is no release containing this feature yet. You can watch for new release to be notified. Le jeu. 17 oct. 2019 à 06:55, sudeshgit <notifications@github.com> a écrit :

…

In which release this change is shipped? I can see 0.8.1 as latest ( https://pypi.org/project/jupyterlab-git/) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#345?email_source=notifications&email_token=ACALK72D3DRFCVDIIYMU3NTQO7V3FA5CNFSM4HJQATW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBOYWMA#issuecomment-543001392>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACALK7Z7OLOD6CKIZN7M5H3QO7V3FANCNFSM4HJQATWQ> .