Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic dialog based on html form #7250

Open
fcollonval opened this issue Sep 20, 2019 · 1 comment
Open

Generic dialog based on html form #7250

fcollonval opened this issue Sep 20, 2019 · 1 comment

Comments

@fcollonval
Copy link
Member

In the following discussion
jupyterlab/jupyterlab-git#345 (comment)
or when I worked on the input dialogs #6326, it appears extensions developers could benefit from a generic form widget similar to the dialog.
That would open the door to Webbrowser validation for example.
Is there any example of such widget? Would it be a nice addition to the base code? Is there other source of inspiration than the Dialog widget?

@bollwyvl
Copy link
Contributor

The 💰 would be react-jsonschema-form. Basically, write (only slightly opinionated) schema, get form.

By default, it carries the bootstrap baggage, and the blueprint theme is hard to reason about because its listed repo isn't public (or something). But, as the rjsf docs rightly suggest, it's possible to do a lot with the relatively concise dom bootstrap does create.

Here's an example of using it in a widget:

(binder) (repo)

Having it in core, integrated with a ui-components theme would make a ton of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants