use encodeURI instead of encodeURIComponent for shareable links (#5340)

tree URLs are documented as `/lab/tree/path/to/notebook.ipynb` not `/lab/tree/path%2Fto%2Fnotebook.ipynb`
jupyterlab · Sep 19, 2018 · c4a9a70 · c4a9a70
1 parent d600547
commit c4a9a70
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/application-extension/src/index.tsx b/packages/application-extension/src/index.tsx
@@ -231,7 +231,7 @@ const tree: JupyterLabPlugin<void> = {
         const treeMatch = args.path.match(Patterns.tree);
         const workspaceMatch = args.path.match(Patterns.workspace);
         const match = treeMatch || workspaceMatch;
-        const path = decodeURIComponent(match[1]);
+        const path = decodeURI(match[1]);
         const { page, workspaces } = app.info.urls;
         const workspace = PathExt.basename(app.info.workspace);
         const url =

diff --git a/packages/filebrowser-extension/src/index.ts b/packages/filebrowser-extension/src/index.ts
@@ -440,7 +440,7 @@ function addCommands(
 
   commands.addCommand(CommandIDs.share, {
     execute: () => {
-      const path = encodeURIComponent(browser.selectedItems().next().path);
+      const path = encodeURI(browser.selectedItems().next().path);
       const tree = PageConfig.getTreeUrl({ workspace: true });
 
       Clipboard.copyToSystem(URLExt.join(tree, path));