Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark tests broken following update of NodeJS in ubuntu image #11606

Closed
fcollonval opened this issue Dec 2, 2021 · 1 comment · Fixed by #11607 or #11623
Closed

Benchmark tests broken following update of NodeJS in ubuntu image #11606

fcollonval opened this issue Dec 2, 2021 · 1 comment · Fixed by #11607 or #11623
Assignees
@fcollonval
Labels
bug
Milestone
4.0.0

Comments

@fcollonval
Copy link
Member

Description

Benchmark tests are failing due to an update of NodeJS in the ubuntu image that is incompatible with CML action (to publish the benchmark image).

Error: The module '/usr/local/lib/node_modules/@dvcorg/cml/node_modules/mmmagic/build/Release/magic.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 93. This version of Node.js requires
NODE_MODULE_VERSION 83.

Reproduce

Execute a benchmark job

Expected behavior

No error
@fcollonval fcollonval added the bug label Dec 2, 2021
@fcollonval fcollonval added this to the 4.0 milestone Dec 2, 2021
@fcollonval fcollonval self-assigned this Dec 2, 2021
fcollonval added a commit to fcollonval/jupyterlab that referenced this issue Dec 2, 2021
@fcollonval
Benchmark tests broken following update of NodeJS in ubuntu image
752fa77 
Fixes jupyterlab#11606
This was referenced Dec 2, 2021
Merged
Closed
fcollonval added a commit to fcollonval/jupyterlab that referenced this issue Dec 3, 2021
@fcollonval
Benchmark tests broken following update of NodeJS in ubuntu image
53ce827 
Fixes jupyterlab#11606
jtpio pushed a commit that referenced this issue Dec 3, 2021
@fcollonval
Benchmark tests broken following update of NodeJS in ubuntu image (#1…
9b00c4e 
…1607)

Fixes #11606
@casperdcl
Copy link

technically should be re-opened as #11607 was a work-around not a fix :)

@0x2b3bfa0 0x2b3bfa0 mentioned this issue Dec 6, 2021
Merged
@fcollonval fcollonval reopened this Dec 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fcollonval fcollonval

Labels
bug
Projects
None yet
Milestone
4.0.0
2 participants
@fcollonval @casperdcl