Fix Benchmark tests (revert #11607)

[0x2b3bfa0]

References

Follow-up for...

• Fixes Benchmark tests broken following update of NodeJS in ubuntu image #11606
• Benchmark tests broken following update of NodeJS in ubuntu image #11607

Code changes

This pull request introduces a better fix for #11606 as per the results of the ongoing investigation at iterative/setup-cml#53 (comment).

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[0x2b3bfa0]

Can be fixed on our side with iterative/setup-cml#55; nevermind.

[0x2b3bfa0]

Leaving this pull request open just to revert #11607

[fcollonval]

Thanks a lot for pushing the revert @0x2b3bfa0

Waiting for the benchmark tests (that are using CML) 🤞

[github-actions]

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table

Test file	large_code_notebook	large_md_notebook
open
chromium
actual	3943 <- [4203 - 4346 - 4896] -> 5694	2625 <- [2775 - 2851 - 3003] -> 3367
expected	3919 <- [4232 - 4360 - 5001] -> 5604	2658 <- [2851 - 2922 - 3125] -> 3443
Mean relative change	0.1% ± 2.8%	-2.5% ± 1.7%
switch-from
chromium
actual	538 <- [612 - 639 - 730] -> 943	402 <- [451 - 506 - 557] -> 602
expected	544 <- [606 - 642 - 808] -> 972	430 <- [462 - 492 - 556] -> 690
Mean relative change	-0.8% ± 4.6%	-1.2% ± 3.1%
switch-to
chromium
actual	663 <- [691 - 709 - 749] -> 910	496 <- [583 - 605 - 636] -> 663
expected	649 <- [715 - 735 - 751] -> 921	509 <- [576 - 635 - 651] -> 670
Mean relative change	-1.2% ± 1.8%	-2.7% ± 1.8%
close
chromium
actual	573 <- [652 - 702 - 943] -> 1103	459 <- [489 - 513 - 572] -> 646
expected	605 <- [659 - 689 - 964] -> 1081	448 <- [503 - 517 - 538] -> 660
Mean relative change	0.7% ± 5.7%	-0.7% ± 2.6%

Changes are computed with expected as reference.

[jtpio]

Thanks for the quick fix!

[jtpio]

CI all green.

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️