-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trademark issue with wrong use of an altered Python logo in Jupyter Lab Launcher #13023
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Thanks @malemburg for reporting this. Posting some information here to help make this happen. For reference the icon is located here: https://github.com/jupyterlab/jupyterlab/blob/master/packages/ui-components/style/icons/filetype/python.svg It's also visible here in the UI: Steps to fix this:
|
Since the problem in principle is with shape and lack of approval, and I like the current colour as it distinguishes the Python file from Python in a notebook, I would like to propose an alternative solution:
To highlight the problem with the current logo: Correct shape, colour as-is: I am not sure if guidelines address the usecase of the logo as in the filebrowser; due to size constraints icons of such size are commonly simplified removing some graphical elements (like the eyes of snakes in this example), which is exactly what PSF website does to its favicon: If we decide to seek permission and get granted an approval to use two variants of the logo (exact shape equivalent in Launcher + simplified/no-eyes in File Browser), we would need to make some more code changes, but it should not be a problem. @malemburg would you be able to offer an informal insight on whether you think that a permission for such a logo (with/without the simplified variant) is likely to be granted? |
I am the other co-chair of the PSF Trademarks Committee along with Marc-André. The version in blue that correctly maintains the shape would be great. If the developers here agree about that, please do send a request to psf-trademarks@python.org for record keeping, but basically it will be approved there. |
As long as the shape is left unchanged (within reason - at low resolutions, this can become difficult), we will be able to approve a blue only variant. Color changes are fine, as long as there is enough contrast with the background and there is a separating space between the logo and any other surrounding graphics. Please note that changes to the shape such as removing the eyes are not permitted. The favicon we use does have the eyes as well. If you want to create a favicon sized logo, it's probably best to start with the variants the PSF is using on the website and simply change the colors. |
The open PR #12673 will actually address this. It replace the Python and Markdown icons with their official icons. |
Per our discussion in our weekly dev call today I will be opening a separate PR to address this later today. |
We discussed this during the weekly meeting and decided by informal vote to replace the blue logo with the original icon (without changing colour to blue). There is a technical issues with gradients in our SVG system: jupyterlab/lumino#160. @malemburg @DavidMertz thank you for your input; would the gradient-less version as presented below (from #12673) require an approval too? |
Please submit this to the TM committee to have a formal record. It'll be approved. |
The current python icon was custom made for JupyterLab in it's early alpha phase and doesn't comply with the PSF Trademark. This replaces that icon with one derived from the offical icon svg as provided at https://www.python.org/community/logos/ In order to support use as a LabIcon and use JupyterLab styling the svg was drastically simlified. The remaining svg uses the same paths and the same colors, but without the opacity gradient. Fixes jupyterlab#13023
The current python icon was custom made for JupyterLab in it's early alpha phase and doesn't comply with the PSF Trademark. This replaces that icon with one derived from the offical icon svg as provided at https://www.python.org/community/logos/ In order to support use as a LabIcon and use JupyterLab styling the svg was drastically simlified. The remaining svg uses the same paths and the same colors, but without the opacity gradient. Fixes jupyterlab#13023
* Update Python icon to be PSF Trademark complient The current python icon was custom made for JupyterLab in it's early alpha phase and doesn't comply with the PSF Trademark. This replaces that icon with one derived from the offical icon svg as provided at https://www.python.org/community/logos/ In order to support use as a LabIcon and use JupyterLab styling the svg was drastically simlified. The remaining svg uses the same paths and the same colors, but without the opacity gradient. Fixes #13023 * Update snapshots * Better reference snapshot * Update new py logo with extra margin space in SVG * Update Playwright Snapshots * Update Playwright Snapshots * Fix new reference snapshot Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Hi there, I am Marc-Andre Lemburg, co-chair of the PSF Trademarks Committee. We have become aware of an issue with the use of the Python logo in Jupyter Lab:
The blue logo changes the shape of the logo and is thus not correct use of the logo according to our trademark guidelines: https://www.python.org/psf/trademarks-faq/
Could you please replace the logo with the correct unchanged logo (as seen for other items in the screenshot) ? That would resolve the issue.
If you have questions regarding the correct use of the Python logo, please write to the PSF Trademarks Committee psf-trademarks@python.org.
Thank you.
Reproduce
Open the "Launcher" in Jupyter Lab.
Expected behavior
See above.
The text was updated successfully, but these errors were encountered: