Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell contents overlap toolbar at narrow width #13115

Open
kulsoomzahra opened this issue Sep 22, 2022 · 5 comments
Open

Cell contents overlap toolbar at narrow width #13115

kulsoomzahra opened this issue Sep 22, 2022 · 5 comments

Comments

@kulsoomzahra
Copy link
Contributor

#13059 PR fixes :

Preserves the horizontal layout of the cell toolbar at 400% zoom

jp

What it doesn't fix:

If the contents of the cell overlap with that of the toolbar, like:

overlap

Steps to reproduce

  • Apply PR Fix cell toolbar layout #13059.
  • Open JupyterLab.
  • Open a notebook that has code cells in it.
  • Squeeze the width of the browser window until it’s below 760 px (the breakpoint)
  • The contents of cell will overlap with the cell toolbar
    (Previously, before PR Fix cell toolbar layout #13059, following the above steps led to the cell toolbar running vertically down the cell.)

Proposed Solution

A possible solution to this issue might be:

  • Giving a solid background to the toolbar with/without borders
  • Offsetting/pushing the toolbar up
  • Adding more white space between cells

(similar to what Google Colab does)

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Sep 22, 2022
@welcome
Copy link

welcome bot commented Sep 22, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@firai
Copy link
Contributor

firai commented Sep 29, 2022

A couple of other proposed solutions to this issue, which I think applies for both regular zoom and increased zoom: #12223

@jtpio jtpio added this to the 4.0.0 milestone Oct 3, 2022
@krassowski
Copy link
Member

Another edge case is the collapsed cells; since I think that it is a bug (cell toolbar gets hidden for non-collapsed cells, but not for collapsed cells) I opened: #13254

@krassowski
Copy link
Member

@JasonWeill do you suggest that we should pause with review of #13896 until we release 4.1?

@andrii-i
Copy link
Contributor

andrii-i commented Feb 2, 2023

@krassowski @JasonWeill PR #13896 solves issue #12523 so I would recommend to either close both PR and an issue or continue review of a PR (then continue work on cell toolbar mobile experience within this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants