Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell toolbar shows up on collapsed cells even when shrunk #13254

Closed
krassowski opened this issue Oct 16, 2022 · 2 comments · Fixed by #13847 or #13964
Closed

Cell toolbar shows up on collapsed cells even when shrunk #13254

krassowski opened this issue Oct 16, 2022 · 2 comments · Fixed by #13847 or #13964
Labels
bug pkg:cell-toolbar
Milestone
4.0.0

Comments

@krassowski
Copy link
Member

krassowski commented Oct 16, 2022 •
edited

Description

Cell toolbar shows up on collapsed cells even when shrunk.

Reproduce

Screenshot from 2022-10-16 22-05-06

  1. Create a second cell, enter it
  2. Collapse the cell
  3. See the cell toolbar stays even when it should be disabled due to space constraints (too narrow window)

Expected behavior

Cell toolbar is either:

  • not visible on collapsed cells
  • not visible on collapsed cells on narrow screens to avoid visual overflow and inability to click on the expand button

Context

  • Browser and version: Chromium
  • JupyterLab version: 3.x and 4.0.0a30
@krassowski krassowski added bug status:Needs Triage Applied to new issues that need triage labels Oct 16, 2022
@krassowski krassowski mentioned this issue Oct 16, 2022
Open
@krassowski krassowski added pkg:cell-toolbar and removed status:Needs Triage Applied to new issues that need triage labels Oct 16, 2022
@JasonWeill JasonWeill added this to the 4.0.0 milestone Jan 23, 2023
@JasonWeill JasonWeill mentioned this issue Jan 23, 2023
Merged
@JasonWeill JasonWeill mentioned this issue Feb 10, 2023
Open
@JasonWeill
Copy link
Contributor

The cell toolbar continues to show up on collapsed cells using JupyterLab 4.0.0a33, as available on Binder here: https://gist.github.com/jtpio/c4b6376bfbd00474b3c0d1d60fe23670

image

@JasonWeill JasonWeill reopened this Feb 10, 2023
@JasonWeill
Copy link
Contributor

Neither the activeCellChanged nor the cellCollapsed events on the Notebook (panel.content) get emitted when I click on the InputCollapser.

@JasonWeill JasonWeill mentioned this issue Feb 10, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug pkg:cell-toolbar
Projects
None yet
Milestone
4.0.0
2 participants
@krassowski @JasonWeill