Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 5 final #13872

Closed
jtpio opened this issue Jan 27, 2023 · 6 comments · Fixed by #14215
Closed

Update to TypeScript 5 final #13872

jtpio opened this issue Jan 27, 2023 · 6 comments · Fixed by #14215

Comments

@jtpio
Copy link
Member

jtpio commented Jan 27, 2023

Problem

TypeScript 5 beta is now available: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/

We should directly update to it for JupyterLab 4.0 since its final release will likely be available before JupyterLab 4 final.

Proposed Solution

Update to TypeScript 5.

Additional context

Some work to update TypeScript had already started in #13028. Although it's been lagging a bit behind and had to go through multiple rebases due to issues in some dependencies.

@jtpio jtpio added this to the 4.0.0 milestone Jan 27, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Jan 27, 2023
@jtpio jtpio added help wanted and removed status:Needs Triage Applied to new issues that need triage labels Jan 27, 2023
@JasonWeill JasonWeill modified the milestones: 4.0.0, 4.1.0 Feb 1, 2023
@krassowski
Copy link
Member

@JasonWeill we cannot do this in 4.1. Could we avoid moving issues which have to be addressed in 4.0 (either because they are regressions or because they require a major version bump) to 4.1 milestone, please?

@krassowski krassowski modified the milestones: 4.1.0, 4.0.0 Feb 2, 2023
@jasongrout
Copy link
Contributor

According to the TS 5.0 timeline, 5.0RC is expected 28 Feb, with 5.0 final released 14 Mar.

+1 to updating to TS 5.0 if possible for jlab 4.0.

@jasongrout
Copy link
Contributor

I submitted a quick PR at #13925 to look at upgrading to TS 5.0 beta.

@jtpio jtpio changed the title Update to TypeScript 5 Update to TypeScript 5 final Feb 20, 2023
@jtpio
Copy link
Member Author

jtpio commented Feb 20, 2023

The update to TypeScript 5 beta landed in #13925.

We can keep this issue open to update to TypeScript 5 final.

@JasonWeill
Copy link
Contributor

@jtpio
Copy link
Member Author

jtpio commented Mar 16, 2023

Nice thanks for the heads up. PR incoming.

@jasongrout jasongrout removed their assignment Mar 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants