Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left panel and right panel resizer is too small to use comfortably #14219

Closed
JasonWeill opened this issue Mar 17, 2023 · 7 comments · Fixed by jupyterlab/lumino#560
Closed

Left panel and right panel resizer is too small to use comfortably #14219

JasonWeill opened this issue Mar 17, 2023 · 7 comments · Fixed by jupyterlab/lumino#560
Assignees
Labels
bug tag:Design and UX tag:Regression Behavior that had been broken, was fixed, and is broken again
Milestone

Comments

@JasonWeill
Copy link
Contributor

Description

The split panel handle (lm-SplitPanel-handle) is very narrow in JupyterLab 4.0.0a34, a35, and a36. This handle is used to resize the left panel or right panel. This control is much more difficult to use than in JupyterLab 3.6.1.

In both cases, the lm-SplitPanel-handle element itself is only 1 px wide, but its clickable area is wider than that (wider in 3.6.1 than in 4.0.0a35).

cc @ellisonbg @andrii-i

Reproduce

Hover over the boundary between the left panel and the main area. Observe that the mouse cursor does not change to the "left-right arrow" cursor nearly as much in 4.0.0 as in 3.6.x.

3.6.1:

jl-3-6.mov

4.0.0a36:

jl-4-0.mov

Expected behavior

There is a wide enough grab handle to comfortably click and drag.

Context

  • Operating System and version: macOS 12.6.3 "Monterey"
  • Browser and version: Firefox 102.8.0esr (64-bit)
  • JupyterLab version: 3.6.1 / 4.0.0a36
@JasonWeill JasonWeill added bug status:Needs Triage Applied to new issues that need triage labels Mar 17, 2023
@JasonWeill JasonWeill added this to the 4.0.0 milestone Mar 17, 2023
@JasonWeill
Copy link
Contributor Author

Not present in 4.0.0a0.

@JasonWeill JasonWeill self-assigned this Mar 17, 2023
@JasonWeill JasonWeill added tag:Design and UX tag:Regression Behavior that had been broken, was fixed, and is broken again labels Mar 17, 2023
@JasonWeill
Copy link
Contributor Author

Not present in 4.0.0a17.

@JasonWeill
Copy link
Contributor Author

Not present in any release before 4.0.0a34. See 4.0.0a34 release notes.

@JasonWeill
Copy link
Contributor Author

Among the differences between 4.0.0a33 and a34 is a substantial CSS update from #13828. I tried deleting these two changes, but the problem persists:

/* disable paint containment from lumino 2.0 default strict CSS containment */
contain: style size !important;

/* relax lumino strict CSS contaiment to allow painting the menu bar item
over the menu in order to create an illusion of partial border */
contain: style size !important;

@JasonWeill
Copy link
Contributor Author

@krassowski I tried to launch a binder from #13828 but was unsuccessful. Do you think that this change may be responsible for the smaller usable area of the panel resizer?

@krassowski
Copy link
Member

Thank you fir bisecting. Yes, we need to add:

/** disable size containment as the handle overhangs over another div */
.lm-SplitPanel-handle {
  contain: style!important;
}

in lumino.

@ellisonbg
Copy link
Contributor

ellisonbg commented Mar 21, 2023 via email

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug tag:Design and UX tag:Regression Behavior that had been broken, was fixed, and is broken again
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants