Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low contrast for line numbers' font color #14254

Closed
JasonWeill opened this issue Mar 22, 2023 · 0 comments · Fixed by #14269
Closed

Low contrast for line numbers' font color #14254

JasonWeill opened this issue Mar 22, 2023 · 0 comments · Fixed by #14269
Assignees
@andrii-i
Labels
bug pkg:codeeditor tag:Accessibility tag:Bug Bash Issue opened during an event to find bugs in a new release tag:CSS For general CSS related issues and pecadilloes tag:Design and UX

Comments

@JasonWeill
Copy link
Contributor

Description

The font color for line numbers in text / code files has a contrast ratio too low for WCAG requirements in both Light and Dark theme.

Screenshot 2023-03-20 at 3 53 38 PM

This was found during a bug bash by @andrii-i.
@JasonWeill JasonWeill added bug tag:Design and UX tag:Accessibility tag:CSS For general CSS related issues and pecadilloes status:Needs Triage Applied to new issues that need triage tag:Bug Bash Issue opened during an event to find bugs in a new release labels Mar 22, 2023
@andrii-i andrii-i self-assigned this Mar 24, 2023
@andrii-i andrii-i mentioned this issue Mar 24, 2023
Merged
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Mar 28, 2023
@andrii-i andrii-i mentioned this issue Mar 28, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrii-i andrii-i

Labels
bug pkg:codeeditor tag:Accessibility tag:Bug Bash Issue opened during an event to find bugs in a new release tag:CSS For general CSS related issues and pecadilloes tag:Design and UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix color contrast of gutter line numbers in code mirror andrii-i/jupyterlab
2 participants
@andrii-i @JasonWeill