Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking away from rendered markdown cell unrenders it #15595

Closed
krassowski opened this issue Jan 2, 2024 · 4 comments · Fixed by #15634
Closed

Clicking away from rendered markdown cell unrenders it #15595

krassowski opened this issue Jan 2, 2024 · 4 comments · Fixed by #15634
Assignees
Labels
bug tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Release Blocker A must-have bug for the milestone to which it is tagged
Milestone

Comments

@krassowski
Copy link
Member

Description

When an active cell is a markdown cell and user clicks on a different cell, the markdown cell unrenders causing content jump thus distraction and annoyance.

Reproduce

clicking-away-unrenders-header

Interestingly, this does not happen when:

  • changing the active cell with arrow keys
  • clicking outside of the notebook or on its toolbar

Expected behavior

Clicking on another cell does not unrender the previous cell.

Context

  • Browser and version: Chrome
  • JupyterLab version: 4.1.0b0

Likely a regression in 4.1.0beta but Binder does not start for me at the moment so I cannot confirm.

@krassowski krassowski added bug status:Needs Triage Applied to new issues that need triage labels Jan 2, 2024
@krassowski krassowski added this to the 4.1.0 milestone Jan 2, 2024
@krassowski krassowski added the tag:Regression Behavior that had been broken, was fixed, and is broken again label Jan 2, 2024
@krassowski
Copy link
Member Author

krassowski commented Jan 2, 2024

Confirmed I do not see this in 4.0.9 nor 3.6.x.

@JasonWeill JasonWeill added tag:Release Blocker A must-have bug for the milestone to which it is tagged and removed status:Needs Triage Applied to new issues that need triage labels Jan 2, 2024
@JasonWeill
Copy link
Contributor

Is this an issue in 4.0.10 as well?

@fcollonval
Copy link
Member

It may be a consequence of #15408

My guess, the focus change switches the notebook to edit mode before the active cell index is updated.

@krassowski krassowski changed the title Clicking away from rendered markdown cell with unrenders it Clicking away from rendered markdown cell unrenders it Jan 8, 2024
@krassowski krassowski self-assigned this Jan 10, 2024
@afonit
Copy link

afonit commented Jan 11, 2024

Is this an issue in 4.0.10 as well?

I do not see this behavior on 4.0.10

example_001

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Release Blocker A must-have bug for the milestone to which it is tagged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants