Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown getting un-rendered when focusing on a different cell #15634

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Fix markdown getting un-rendered when focusing on a different cell #15634

merged 2 commits into from
Jan 13, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jan 13, 2024 •
edited
Loading

References

Fixes #15595

Code changes

  • Add regression unit test
  • Move change of active index ahead of mode enforcement as it assumes the active index is already set

User-facing changes

Before After
before after

Backwards-incompatible changes

None

@krassowski krassowski added the bug label Jan 13, 2024
@krassowski krassowski added this to the 4.1.0 milestone Jan 13, 2024
@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski marked this pull request as ready for review January 13, 2024 12:56
jtpio
jtpio approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski
Copy link
Member Author

Thanks! Merging - the visual docs failure is unrelated (#15635).

@krassowski krassowski merged commit 83b2ae9 into jupyterlab:main Jan 13, 2024
77 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@krassowski krassowski

Labels
bug pkg:notebook
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Clicking away from rendered markdown cell unrenders it
2 participants
@krassowski @jtpio