Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "Folder", not "Directory", in file browser settings #16231

Closed
JasonWeill opened this issue Apr 24, 2024 · 3 comments
Closed

Use "Folder", not "Directory", in file browser settings #16231

JasonWeill opened this issue Apr 24, 2024 · 3 comments
Assignees
@Rob-P-Smith
Labels
enhancement status:Needs Triage Applied to new issues that need triage tag:Settings
Milestone
4.2.0

Comments

@JasonWeill
Copy link
Contributor

Problem

Although directory is used in command names, our UI uses folder in the file browser:

image

(Note that the above command is "create-new-directory", thanks @andrii-i for the screenshot)

Two settings in the advanced settings editor, "Navigate to current directory" and "Filter directories", use directory, not folder.

image

Proposed Solution

Use folder consistently in the user interface. Renaming commands is not necessary.

Additional context
@JasonWeill JasonWeill added enhancement tag:Settings status:Needs Triage Applied to new issues that need triage labels Apr 24, 2024
Rob-P-Smith added a commit to Rob-P-Smith/jupyterlab that referenced this issue Apr 24, 2024
@Rob-P-Smith
Update browser.json
a305b31 
Adjusted wording to satisfy issue #16321

Use "Folder", not "Directory", in file browser settings jupyterlab#16231
@Rob-P-Smith
Copy link
Contributor

Rob-P-Smith commented Apr 24, 2024 •
edited

I am done with the change requested and verified desired behavior.

I can't submit a pull request yet as it's not assigned/traiged etc.

folder

@JasonWeill
Copy link
Contributor Author

@Rob-P-Smith Thank you so much for your interest! Please feel free to open a pull request when you're ready.

@Rob-P-Smith Rob-P-Smith mentioned this issue Apr 24, 2024
Merged
krassowski added a commit that referenced this issue Apr 26, 2024
@Rob-P-Smith @pre-commit-ci
@github-actions @krassowski
Update wording from directory to folder in user interface (#16234)
4733f95 
* Update browser.json

Adjusted wording to satisfy issue #16321

Use "Folder", not "Directory", in file browser settings #16231

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue #16025

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue #16025

* Delete Untitled.ipynb

* Delete Untitled1.ipynb

* Updating Docs

Changed all instances of 'directory' to 'folder' to start.

Reviewing videos for those which need to be updated to reflect the changes made for this issue.

* Updating 'directory' to 'folder'

* Updating 'directory' to 'folder'

* Adjusting 'directory' to 'folder' when referencing locations inside jupyterlab but not local file structures.

* Removing start.sh from gitignore

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update Playwright Snapshots

* Update Playwright Snapshots

* Revert unrelated changes

* Revert snapshot changes and docker/start.sh change

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@krassowski
Copy link
Member

Closing as fixed by #16234.

@krassowski krassowski added this to the 4.2.0 milestone Apr 26, 2024
gderocher pushed a commit to gderocher/jupyterlab that referenced this issue Apr 26, 2024
@Rob-P-Smith @pre-commit-ci
@github-actions @krassowski @gderocher
Update wording from directory to folder in user interface (jupyterlab…
17884c6 
…#16234)

* Update browser.json

Adjusted wording to satisfy issue #16321

Use "Folder", not "Directory", in file browser settings jupyterlab#16231

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue jupyterlab#16025

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue jupyterlab#16025

* Delete Untitled.ipynb

* Delete Untitled1.ipynb

* Updating Docs

Changed all instances of 'directory' to 'folder' to start.

Reviewing videos for those which need to be updated to reflect the changes made for this issue.

* Updating 'directory' to 'folder'

* Updating 'directory' to 'folder'

* Adjusting 'directory' to 'folder' when referencing locations inside jupyterlab but not local file structures.

* Removing start.sh from gitignore

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update Playwright Snapshots

* Update Playwright Snapshots

* Revert unrelated changes

* Revert snapshot changes and docker/start.sh change

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
krassowski added a commit that referenced this issue Apr 26, 2024
@Rob-P-Smith @github-actions
@pre-commit-ci @krassowski
Harmonize the use of ellipses in command and menu items (#16237)
d84e8e0 
* Update browser.json

Adjusted wording to satisfy issue #16321

Use "Folder", not "Directory", in file browser settings #16231

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue #16025

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue #16025

* Delete Untitled.ipynb

* Delete Untitled1.ipynb

* Update Playwright Snapshots

* Update Playwright Snapshots

* Corrections Applied per JasonWeill's feedback.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update Playwright Snapshots

* Update Playwright Snapshots

* Revert unrelated changes

* Fix test

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rob-P-Smith Rob-P-Smith

Labels
enhancement status:Needs Triage Applied to new issues that need triage tag:Settings
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
3 participants
@krassowski @JasonWeill @Rob-P-Smith