-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension Compatiblity #2410
Extension Compatiblity #2410
Conversation
Going to wait until #2409 is merged to finish this, since there will be a lot of overlap. |
34f27e8
to
b6f35ed
Compare
Trying some things out with this branch: First I ran:
I then saw this: (python34) $ jupyter labextension list
[ListLabExtensionsApp] JupyterLab v0.23.2
[ListLabExtensionsApp] Known labextensions:
[ListLabExtensionsApp]
Uninstalled core extensiosn:
[ListLabExtensionsApp] @jupyterlab/help-extension But when I tried to install that extension again I got a Python exception that ended with: ValueError: @jupyterlab/help-extension is not a valid JupyterLab extension |
I tried to link/unlink the |
jupyterlab/commands.py
Outdated
|
||
# Handle uninstalled and disabled core packages | ||
uninstalled_core = _get_uinstalled_core_extensions(app_dir) | ||
if uninstalled_core: | ||
print('\nUninstalled core extensiosn:') | ||
[print(' %s' % item) for item in sorted(uninstalled_core)] | ||
logger.info('\nUninstalled core extensiosn:') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extensiosn
4221c8a
to
c5ef47e
Compare
Tested latest changes locally and all is happy. Once the tests pass, let's merge! |
Come on Travis! |
Fixes #2356.
Note: Populated the
singletonPackages
using the packages that export a token and@phosphor/widgets
, which comprises the packages that are explicitly shared.Sample output:
TODO:
list
- show as invalid, offer verbose mode with full reportpackage.json