Development build instructions off in README

[ellisonbg]

The instructions in the README for dev builds work fine if you haven't made any changes. But if you want to actually do development, there are missing pieces. I thought I could get away with just doing an npm run build in the top-level directory, but that doesn't seem to do it.

I dug around and found that python setup.py jsdeps does the trick. Is this the preferred approach? Do we want to add a top level npm command that does everything?

[jasongrout]

Sure, that would be great to have a top-level npm command that builds and then builds the extension subpackage. Submit a PR!

[ellisonbg]

I have no idea how to get npm to do that and am going offline until next
Wed starting tomorrow after our JupyterLab meeting ;-)

On Thu, Jun 9, 2016 at 6:43 PM, Jason Grout notifications@github.com
wrote:

Sure, that would be great to have a top-level npm command that builds and
then builds the extension subpackage. Submit a PR!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#27 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABr0M5RE6Yty1jSPJB8gw2OEnHvOPa0ks5qKMFPgaJpZM4Iygmb
.

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

[jasongrout]

Workflow A: have npm run build build the jupyterlab code, then install it into the extension, then update the extension bundle. It would be great to have an npm run watch or something that could do this automatically when a file changed too.

Workflow B: have an npm run watch in the jupyterlab directory, so you first go into the jupyterlab directory and run npm run watch, then as you make changes to the jupyterlab ts source, and run npm run build, the extension updates itself.

[Carreau]

Ping @ian-r-rose , @fperez

[fperez]

While having a run watch open is probably a good idea for dev work (and should be documented :), would it also help to have a git hook like we have for j/notebook?

[Carreau]

Sidenote,

npm install run post_install and prepublish which end up running all the test ....etc which seem undesirable.

[jasongrout]

@Carreau - this is a problem with npm. See npm/npm#3059 (and npm/npm#8402, and finally npm/npm#10074, which is still open).

[jasongrout]

This issue I think is fixed with #75 (when it is merged...)

[jasongrout]

Fixed by #75.

[Carreau]

Thanks ! And yes I was 1/2 aware it was a npm issue.