Pluggable latex #2974
Pluggable latex #2974
Conversation
packages/rendermime/src/renderers.ts
Outdated
| @@ -135,6 +138,11 @@ namespace renderHTML { | |||
| * Whether the node should be typeset. | |||
| */ | |||
| shouldTypeset: boolean; | |||
|
|
|||
| /** | |||
| * The Latex typesetter for the application. | |||
There was a problem hiding this comment.
Perhaps, "The LaTeX typesetter" here as well?
There was a problem hiding this comment.
(same in other places in this file)
There was a problem hiding this comment.
I agree. Probably not for type and variable names, though?
packages/rendermime/src/latex.ts
Outdated
| * Construct the typesetter. | ||
| */ | ||
| constructor() { | ||
| this._init(); |
There was a problem hiding this comment.
Perhaps not init here so we don't call this unless we actually render something.
| @@ -13,7 +13,7 @@ import 'codemirror/addon/mode/multiplex'; | |||
| * Define an IPython GFM (GitHub Flavored Markdown) mode. | |||
| * | |||
| * Is just a slightly altered GFM Mode with support for latex. | |||
There was a problem hiding this comment.
Could you also fix the capitalisation there too?
|
I'm a little confused as to how this allows both the async and synchronous processing models that MathJax and KaTeX embody (respectively). Could the docs explain that in case someone wants to extend this for a third math processing engine? |
|
Basically, the |
|
Great, thanks! |
|
this is awesome |
lock
bot
added
the
status:resolved-locked
Adresses #2280. This adds a
latexTypesetterproperty to the application rendermime. It defaults to an implementation using MathJax, but can be swapped for one using another renderer (such as KaTeX). A proof-of-concept extension for KaTeX is here.cc @jasongrout @mpacer