Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Theme editor #3928

Closed
vidartf opened this issue Feb 21, 2018 · 4 comments
Closed

Idea: Theme editor #3928

vidartf opened this issue Feb 21, 2018 · 4 comments
Labels
feedback tag:Extension Idea Ideas for interesting extensions that live outside of JupyterLab core.
Milestone

Comments

@vidartf
Copy link
Member

vidartf commented Feb 21, 2018

Given the number of issues with theming, and the wish of many users to fully customize their look and feel, it would make sense to make it easier to make theme extensions. The most streamlined way to do this would be to make a "Theme editor" directly in lab. The design would of course be left to whoever implements this, but here are some aspects that I imagine:

  • The editor would be a lab-extension, so that the theme can be edited directly from jupyterlab.
  • Installed themes are read-only, but can be used as a basis for editing your own.
  • Maybe use existing settings UI as a base for editing the theme?
  • Edited theme is kept in-memory, but with an option to save it out as an extension.

If anyone wants to take this on, it would probably be best to create it as a third-party extension, which could then be considered for inclusion in the core later on.

@vidartf
Copy link
Member Author

vidartf commented Feb 21, 2018

it would probably be best to create it as a third-party extension

That being said, there might be a need for a feature in the core for "hot-loading" a theme? I'm not familiar enough with the underpinnings of the theme system.

@zkghost
Copy link

zkghost commented May 24, 2018

What is the current method for developing your own theme? I've spent an hour without luck trying to manually add folders in different spots and failing to run the jlpm run create:theme command.

@jasongrout jasongrout added the tag:Extension Idea Ideas for interesting extensions that live outside of JupyterLab core. label Jul 6, 2018
@jasongrout
Copy link
Contributor

@zkghost - I would copy a current theme (like https://github.com/jupyterlab/jupyterlab/tree/master/packages/theme-light-extension) to a directory, then modify it to suit your needs. The current themes should be essentially self-contained, and would be good starting points for other themes.

@jtpio
Copy link
Member

jtpio commented Jun 20, 2023

Closing as this has now been implemented in https://github.com/jupyterlab-contrib/jupyterlab-theme-editor.

There is also a blog post about the extension: https://blog.jupyter.org/a-theme-editor-for-jupyterlab-8f08ab62894d

Thanks @HaudinFlorence for working on this!

@jtpio jtpio closed this as completed Jun 20, 2023
@jtpio jtpio modified the milestones: Future, Reference Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback tag:Extension Idea Ideas for interesting extensions that live outside of JupyterLab core.
Projects
None yet
Development

No branches or pull requests

6 participants