Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html images in markdown do not update when cell is rerun #4589

Closed
SimonEnsemble opened this issue May 16, 2018 · 5 comments
Closed

html images in markdown do not update when cell is rerun #4589

SimonEnsemble opened this issue May 16, 2018 · 5 comments
Labels
bug pkg:cells status:Needs Info status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@SimonEnsemble
Copy link

If I put the following html tag in a markdown cell:

#### blah blah

<center>
    <img src="myimage.png" width=500>
</center>

and run the cell, the image displays properly. However, if I change the image myimage.png, go into the cell again and hit play again, the image displayed does not update; it instead displays the old image before it was updated. This is kind of a problem for when I'm preparing presentations in Jupyter Lab. Thanks.

@dansteingart
Copy link

I'm seeing a bug for all images in version 0.32.1 that did not exist in 0.31.12

Here's 0.31.12

image

Here's 0.32.1

image

@ian-r-rose
Copy link
Member

Hi @SimonEnsemble, sorry for the slow reply. Your image is not updating because we don't re-render the markdown cell if the source has not changed. We may want to revisit that decision, but for now you can get the altered image to show up by changing the text anywhere (by, for instance, adding a space somewhere).

@dansteingart I am unable to reproduce your issue with any images except the one you linked to. Might that file be corrupted in some way?

@dansteingart
Copy link

dansteingart commented May 29, 2018 via email

@ian-r-rose
Copy link
Member

ian-r-rose commented May 29, 2018

Ah, I think this may be fixed on master (by #4613). On 0.32.1 we are mistakenly adding a query string to some URLs, which makes some external image loads succeed, and others fail. The fix should be in the released packages in a week or two.

@blink1073 blink1073 added this to the Future milestone Sep 11, 2018
@jasongrout
Copy link
Contributor

This issue is actually two separate issues. Closing as the original issue is answered, and the second issue should be fixed. @dansteingart - please comment below (or open another issue) if you are still not seeing an image.

@jasongrout jasongrout modified the milestones: Future, 1.0, Reference Sep 11, 2018
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:cells status:Needs Info status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

6 participants